Avoid deprecation warning in NVHPC #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz4rs
force-pushed
the
nvhpc-deprecation-warning
branch
from
71bda6f
to
15f8d9c
Compare
cz4rs
commented
Aug 8, 2022
| @@ -182,7 +182,7 @@ State::State(IterationCount max_iters, const std::vector<int64_t>& ranges, | |||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Winvalid-offsetof" | |||
| #endif | |||
| #if defined(__CUDACC__) | |||
| #if defined(__NVCC__) | |||
There was a problem hiding this comment.
Not directly related: use more general identification macro for compiler detection.
Reference: https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#nvcc-identification-macro.
dmah42
approved these changes
Aug 8, 2022
|
great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1458
NVHPC does not respect silencing the warning with
BENCHMARK_DISABLE_DEPRECATED_WARNING. I was unable to find suitable option for#pragma nv_diag_suppress, so when NVCC is detected just skip the deprecated attribute (as is done in the#elsesection).