Fix Clang-Tidy warnings related to modernize-use-override #1523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have the problem that we have the static code analysis of MSVC enabled, but some warnings cannot be marked as errors, because they come into our code via macros, where the definition of external/system includes does not help. One issue is C26435 (
Use single virtual specification
).For this MR I checked all warnings related:
Furthermore I replaced all
BENCHMARK_OVERRIDE
byoverride
within allcc
files (as the readme states that C++11 is required to compile this framework and there was already sometimes usedoverride
without the macro) - the header files are still usingBENCHMARK_OVERRIDE
to keep C++03 compatibility.