Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang-Tidy warnings related to modernize-use-override #1523

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Jan 9, 2023

Currently we have the problem that we have the static code analysis of MSVC enabled, but some warnings cannot be marked as errors, because they come into our code via macros, where the definition of external/system includes does not help. One issue is C26435 (Use single virtual specification).

For this MR I checked all warnings related:

Furthermore I replaced all BENCHMARK_OVERRIDE by override within all cc files (as the readme states that C++11 is required to compile this framework and there was already sometimes used override without the macro) - the header files are still using BENCHMARK_OVERRIDE to keep C++03 compatibility.

@dmah42 dmah42 merged commit 37faf6f into google:main Jan 9, 2023
@dmah42
Copy link
Member

dmah42 commented Jan 9, 2023

thanks!

@SunBlack SunBlack deleted the modernize-use-override branch January 9, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants