Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Provide public accessors to benchmark name and arguments #1551 #1563

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

gatorfax
Copy link
Contributor

@gatorfax gatorfax commented Mar 6, 2023

No description provided.

@gatorfax
Copy link
Contributor Author

gatorfax commented Mar 6, 2023

#1551

dmah42
dmah42 previously approved these changes Mar 7, 2023
@gatorfax
Copy link
Contributor Author

gatorfax commented Mar 9, 2023

only fails with VS'19 release build?

https://github.com/google/benchmark/actions/runs/4377778378/jobs/7661688230#step:7:5141

65: BM_Complexity_O_N/2048         D:\a\benchmark\benchmark\test\output_test_helper.cc:115: internal::`anonymous-namespace'::CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_log_N_RMS                       11 %            86 %    " to match regex "^%rms_name %rms %rms[ ]*$"
65:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
65:     started matching near: BM_Complexity_O_N_log_N_RMS                       11 %            86 %    
65/74 Test #65: complexity_benchmark .......................Exit code 0xc0000409
***Exception:   2.11 sec

any ideas?

@dmah42
Copy link
Member

dmah42 commented Mar 10, 2023

only fails with VS'19 release build?

https://github.com/google/benchmark/actions/runs/4377778378/jobs/7661688230#step:7:5141

65: BM_Complexity_O_N/2048         D:\a\benchmark\benchmark\test\output_test_helper.cc:115: internal::`anonymous-namespace'::CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_log_N_RMS                       11 %            86 %    " to match regex "^%rms_name %rms %rms[ ]*$"
65:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
65:     started matching near: BM_Complexity_O_N_log_N_RMS                       11 %            86 %    
65/74 Test #65: complexity_benchmark .......................Exit code 0xc0000409
***Exception:   2.11 sec

any ideas?

i think we have a test that gets optimized out so instead of being O(N log(N)) it ends up looking like constant time. it's not a critical test to pass so i'm happy to wave it through.

@dmah42 dmah42 merged commit f32748c into google:main Mar 10, 2023
dmah42 pushed a commit that referenced this pull request Mar 10, 2023
…1563)

* [FR] Provide public accessors to benchmark name and arguments #1551

* Update AUTHORS and CONTRIBUTORS

* Update benchmark_register.cc

* Fix lint formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants