Add a Python matrix to ensure the bindings build on all supported versions #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3.13 is unhappy. |
|
Ah yeah, I didn't commit the 3.13 toolchain def in MODULE.bazel. Just a second |
nicholasjng
force-pushed
the
extend-python-ci
branch
from
8778a16
to
18c6105
Compare
…sions Also contains a run of `pre-commit autoupdate`, and a bump of cibuildwheel to its latest tag for CPython 3.13 support. But, since we build for 3.10+ with SABI from 3.12 onwards, we don't even need a dedicated Python 3.13 build job or toolchain - the wheels from 3.12 can be reused. Simplifies some version-dependent logic around assembling the bazel build command in setup.py, and fixes a possible unbound local error in the toolchain patch context manager.
nicholasjng
force-pushed
the
extend-python-ci
branch
from
18c6105
to
f635f1c
Compare
|
I decided to extend the SABI argument to The current setup should now stay in place until either a free-threaded wheel is needed, or the minimum required Python is bumped (which is a few years away). |
dmah42
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains a run of
pre-commit autoupdate, and a bump of cibuildwheel to its latest tag for CPython 3.13 support.But, since we build for 3.10+ with SABI from 3.12 onwards, we don't even need a dedicated Python 3.13 build job - the wheels from 3.12 can be reused.