Fix remaining lint errors and emit lint errors in travis (#669)

google · Apr 15, 2021 · 1be2b74 · 1be2b74
1 parent 331255b
commit 1be2b74
Show file tree

Hide file tree

Showing 6 changed files with 351 additions and 319 deletions.
diff --git a/plugins/dev-scripts/config/webpack.config.js b/plugins/dev-scripts/config/webpack.config.js
@@ -97,7 +97,7 @@ module.exports = (env) => {
               options: {
                 cache: true,
                 formatter: 'stylish',
-                emitWarning: true,
+                emitWarning: isDevelopment,
                 eslintPath: require.resolve('eslint'),
                 resolvePluginsRelativeTo: __dirname,
                 useEslintrc: false,

diff --git a/plugins/dev-tools/src/common_test_helpers.mocha.js b/plugins/dev-tools/src/common_test_helpers.mocha.js
@@ -57,7 +57,7 @@ TestSuite.prototype.testCases = [];
  *    callback using given test case.
  */
 export function runTestCases(testCases, createTestCallback) {
-  testCases.forEach(/** @type {!TestCase} */(testCase) => {
+  testCases.forEach((testCase) => {
     let testCall = (testCase.skip ? test.skip : test);
     testCall = (testCase.only ? test.only : testCall);
     testCall(testCase.title, createTestCallback(testCase));
@@ -66,14 +66,14 @@ export function runTestCases(testCases, createTestCallback) {
 
 /**
  * Runs provided test suite.
- * @template {TestCase} T
+ * @template {TestSuite} T
  * @param {Array<!TestSuite<T>>} testSuites The test suites to run.
  * @param {function(!TestSuite<T>):(function(T):!Function)
  *    } createTestCaseCallback Creates test case callback using given test
  *    suite.
  */
 export function runTestSuites(testSuites, createTestCaseCallback) {
-  testSuites.forEach(/** @type {!TestSuite} */(testSuite) => {
+  testSuites.forEach((testSuite) => {
     let suiteCall = (testSuite.skip ? suite.skip : suite);
     suiteCall = (testSuite.only ? suite.only : suiteCall);
     suiteCall(testSuite.title, function() {
@@ -92,7 +92,7 @@ export function captureWarnings(innerFunc) {
   const msgs = [];
   const nativeConsoleWarn = console.warn;
   try {
-    console.warn = function (msg) {
+    console.warn = function(msg) {
       msgs.push(msg);
     };
     innerFunc();