New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugs in the new debug renderer #1016

Merged

alschmiedt merged 2 commits into google:master from alschmiedt:fix_debug_renderer

Feb 23, 2022

Contributor

alschmiedt commented Feb 23, 2022

Fixes two bugs with the debug renderer that were found when testing with core blockly.

I changed the name of the folder to make it more readable in my last commit. This was bad because the folder name is also mapped to the name of the field it corresponds to on the object.
When you have an old bag of options it fails because the defaultState is not used and so it does not have any default value.

alschmiedt added 2 commits

February 23, 2022 14:03


          fix: the debug renderer

511b219


          fix: bug with loading old options bag

alschmiedt assigned BeksOmega

alschmiedt requested a review from BeksOmega

February 23, 2022 22:50

BeksOmega approved these changes

View reviewed changes

alschmiedt merged commit e4aaae7 into google:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet