chore: fix failing build due to legacy-peer-dependencies #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Aug 5, 2024
BeksOmega
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes the publish failures. (ref: https://github.com/google/blockly-samples/actions/runs/10202672819/job/28227560061)
I think this is a result of the fact that we're now using legacy peer deps in samples, so peer deps that were previously being installed are now not.
I am confused about why NPM gets angry about not having typescript in the react plugin when we only have an optional peer dep on it from a downstream
react-scriptsdependency. But there's only so much time I'm willing to dedicate to this.