Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the eslint version in root and remove unnecessary suppress annotations #985

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

maribethb
Copy link
Contributor

  1. Lerna does not automatically update the version of @blockly/eslint-config in the root level because I guess the root level isn't managed by lerna. This is the only plugin affected by this. This is the cause of those "visibility is not a type" lint warnings, which are fixed in the updated version of eslint-plugin-jsdoc which is required in the newest version of eslint-config but wasn't being pulled in. So I updated it.
  2. Removed the 2 @suppress annotations. These are for suppressing errors in the Closure compiler which we don't use in samples. They were probably left over from when we pulled stuff out of core. The reason this is related to the first change is because it's the suppress annotations that were throwing the warning that I was trying to deal with in 1
  3. As part of trying to get the version to update I deleted all the package locks and recreated them so idk here they are, enjoy. I think the version numbers themselves got updated after the recent release
  4. As of this moment there are no lint errors or warnings in samples. Savor the feeling!

@maribethb maribethb merged commit cacc4f7 into google:master Feb 3, 2022
@maribethb maribethb deleted the suppress branch February 3, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants