Skip to content

Commit

Permalink
chore(deps): Remove dependency on babel-eslint; simplify eslintrc f…
Browse files Browse the repository at this point in the history
…or mocha tests (#5794)

* chore(deps): Remove deprecated babel-lint package

  When dependabot submitted PR #5791, it became apparent that eslint
  version >= 8 is incompatible with babel-eslint v10.1.0 despite the
  latter not having a version restriction against it.  This is probably
  because v10.1.0 is the last version of the package before it was
  deprecated and renamed @babel/eslint-parser.

  A little more investigation determined that there is no longer any
  need to have eslint use a non-default parser for tests/mocha/**/*.js,
  so the most straight forward solution is just to remove the dependency
  entirely.

* refactor(tests): Simplify tests/mocha/.eslintrc.json

  Remove all rules that seem to be redundant with our top-level
  .eslintrc.json.

  This finishes reverting most of the changes made in PR #4062.
  • Loading branch information
cpcallen authored Dec 10, 2021
1 parent 6ed2b6a commit ec6bf32
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 324 deletions.
300 changes: 0 additions & 300 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"@blockly/dev-tools": "^2.6.1",
"@blockly/theme-modern": "^2.1.1",
"@wdio/selenium-standalone-service": "^7.10.1",
"babel-eslint": "^10.1.0",
"chai": "^4.2.0",
"clang-format": "^1.6.0",
"closure-calculate-chunks": "^3.0.2",
Expand Down
Loading

0 comments on commit ec6bf32

Please sign in to comment.