Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete styles without associated classes from css.ts #8285

Closed
BeksOmega opened this issue Jul 10, 2024 · 7 comments
Closed

Delete styles without associated classes from css.ts #8285

BeksOmega opened this issue Jul 10, 2024 · 7 comments
Assignees
@aishwaryavenkatesan
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

The following styles exist in css.ts but the classes are never actually applied anywhere in core. We should delete the styling.

  • blocklyHidden
  • blocklyResizeLine
  • blocklyResizeSW
  • blocklyResizeSE
  • blocklyDropDownButton

If you want to work on this issue, please comment below asking to be assigned.

This should be merged into the rc/v12.0.0 branch. It should be marked as a breaking change.
@BeksOmega BeksOmega added this to the v12 milestone Jul 10, 2024
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited good first issue labels Jul 10, 2024
@aishwaryavenkatesan
Copy link

Hi I am looking to contribute to open source for the first time, can I work on this issue?

@BeksOmega
Copy link
Collaborator Author

Hiya @aishwaryavenkatesan awesome! Absolutely :D Let me know if you have any questions!

@aishwaryavenkatesan
Copy link

Thank you @BeksOmega, just read through on the fork and clone, will post here if I have any doubts!

@Suswetha6
Copy link

Hey @BeksOmega ,i want to work on this issue

aishwaryavenkatesan added a commit to aishwaryavenkatesan/blockly-av that referenced this issue Aug 5, 2024
@aishwaryavenkatesan
fix: deleted styles without associated classes from css.ts, issue goo…
8b10c8e 
…gle#8285
@aishwaryavenkatesan aishwaryavenkatesan mentioned this issue Aug 5, 2024
Merged
5 tasks
@aishwaryavenkatesan
Copy link

Hi @BeksOmega, i have committed my changes, would it be possible to review my PR?

@BeksOmega
Copy link
Collaborator Author

Hi @aishwaryavenkatesan I try to review daily (on work days) =)

@aishwaryavenkatesan
Copy link

perfect, thanks for the reply and my first contribution to Open Source

aishwaryavenkatesan added a commit to aishwaryavenkatesan/blockly-av that referenced this issue Aug 6, 2024
@aishwaryavenkatesan
fix: deleted styles without associated classes from css.ts, issue goo…
1e63985 
…gle#8285
BeksOmega pushed a commit that referenced this issue Aug 7, 2024
@aishwaryavenkatesan
fix!: deleted styles without associated classes from css.ts, issue #8285
68dda11 
 (#8465)
@BeksOmega BeksOmega added size: small Bugs that can be picked up and completed in 1-3 days and removed good first issue labels Aug 13, 2024
@gonfunko gonfunko mentioned this issue Nov 6, 2024
Merged
1 task
@gonfunko gonfunko closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aishwaryavenkatesan aishwaryavenkatesan

Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Projects
None yet
Milestone
v12
Development

No branches or pull requests
4 participants
@gonfunko @BeksOmega @aishwaryavenkatesan @Suswetha6