Connection Tracking Pt 3: Changed connections to use 'tracked_' property #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture PR, but I want to focus on cleaning connections).
BeksOmega
force-pushed
the
fixes/ConnectionTracking
branch
from
edf203b
to
f217320
Compare
|
Holding until after we cut the release (tomorrow) |
…ogic. Moved it to the constructor.
|
Good call on the naming. It feels less awkward. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
N/A
Proposed Changes
Changes all reference to
hidden_orinDb_totracked_.There were also quite a few picky doc changes that went with this.
Reason for Changes
These meant /slightly/ different things before, but they were similar enough that it seemed weird to have two properties. It also seemed confusing to have a property named 'hidden_' that didn't always reflect the visibility of the connection (since it had to do with database tracking, not visibility).
Test Coverage
Already has tests coverage.
Reenabed two disable tests.
Tested on:
Documentation
N/A
Additional Information
Related to #2994