Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#3248
Proposed Changes
Reverts a change made by #2247 (it was just meant for efficiency).
Reason for Changes
It broke things, because
onScroll_
was no longer getting called.Test Coverage
Bounds resizing
Cleanup blocks
Tested on:
Documentation
N/A
Additional Information
We could also add a call to
this.centerOnBlock(topBlocks[0]);
at the end ofworkspace.cleanUp
if you want @NeilFraser .