Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed block cleanup #3274

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#3248

Proposed Changes

Reverts a change made by #2247 (it was just meant for efficiency).

Reason for Changes

It broke things, because onScroll_ was no longer getting called.

Test Coverage

Bounds resizing

  1. Attempted to drag a block outside of the workspace bounds.
  2. Observed how scrollbars resized to show the block.

Cleanup blocks

  1. Moved blocks to high x-coordinates.
  2. Cleaned up blocks.
  3. Observed how blocks were still in view.

Tested on:

  • Desktop Chrome

Documentation

N/A

Additional Information

We could also add a call to this.centerOnBlock(topBlocks[0]); at the end of workspace.cleanUp if you want @NeilFraser .

Copy link
Contributor

@samelhusseini samelhusseini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BeksOmega

@samelhusseini samelhusseini merged commit 8407428 into google:develop Oct 16, 2019
@BeksOmega BeksOmega deleted the fixes/CleanupBlocks branch November 11, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants