Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/utils/colour.js to goog.module syntax #5045

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Migrate core/utils/colour.js to goog.module syntax #5045

merged 3 commits into from
Jul 15, 2021

Conversation

moniika
Copy link
Contributor

@moniika moniika commented Jul 13, 2021 •
edited
Loading

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test locally already.

The details

Resolves

Part of #5026

Proposed Changes

Converts core/utils/colour.js to goog.module syntax.

Test Coverage

Ran npm run start and npm run test

@moniika moniika requested a review from a team as a code owner July 13, 2021 22:41
@moniika moniika requested a review from cpcallen July 13, 2021 22:41
@moniika moniika changed the title Convert colour Convert colour to goog.module syntax Jul 14, 2021
@moniika moniika force-pushed the convert-colour branch 5 times, most recently from 6d35718 to fb71c50 Compare July 14, 2021 01:33
@moniika moniika added this to the 2021_q3_release milestone Jul 14, 2021
@moniika moniika changed the title Convert colour to goog.module syntax Migrate core/utils/colour.js to goog.module syntax Jul 14, 2021
cpcallen
cpcallen reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, except that I realise there is a style issue we should probably decide before merging this—see below.

core/utils/colour.js Show resolved Hide resolved
@moniika moniika requested a review from cpcallen July 14, 2021 22:07
@moniika moniika force-pushed the convert-colour branch 2 times, most recently from 3de1cd1 to d1a77a7 Compare July 14, 2021 22:33
@moniika moniika merged commit f63bf29 into google:goog_module Jul 15, 2021
@moniika moniika deleted the convert-colour branch July 16, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcallen cpcallen cpcallen approved these changes

Assignees
No one assigned
Labels
type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
2 participants
@moniika @cpcallen