Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/utils/deprecation.js to goog.module syntax #5048

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Migrate core/utils/deprecation.js to goog.module syntax #5048

merged 3 commits into from
Jul 14, 2021

Conversation

moniika
Copy link
Contributor

@moniika moniika commented Jul 14, 2021

The basics

  • [ ] I branched from develop
  • [ ] My pull request is against develop
  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide

The details

Resolves

Part of #5026

Proposed Changes

Converts core/utils/deprecation.js to goog.module syntax.

Test Coverage

Ran npm run start and npm run test

@moniika moniika added this to the 2021_q3_release milestone Jul 14, 2021
@moniika moniika requested a review from a team as a code owner July 14, 2021 01:43
@moniika moniika changed the title Convert deprecation to goog.module syntax Migrate core/utils/deprecation.js to goog.module syntax Jul 14, 2021
@moniika moniika merged commit 819a0f1 into google:goog_module Jul 14, 2021
@moniika moniika deleted the convert-deprecation branch July 16, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees
No one assigned
Labels
type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@moniika @rachel-fenichel @cpcallen