Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/utils/idgenerator.js to goog.module syntax #5056

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Migrate core/utils/idgenerator.js to goog.module syntax #5056

merged 1 commit into from
Jul 14, 2021

Conversation

alschmiedt
Copy link
Contributor

@alschmiedt alschmiedt commented Jul 14, 2021 •
edited
Loading

The basics

  • I branched from goog.module
  • My pull request is against goog.module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test locally already.

The details

Resolves

Part of #5026

Additional Information

@alschmiedt alschmiedt requested a review from a team as a code owner July 14, 2021 18:05
@alschmiedt alschmiedt requested a review from cpcallen July 14, 2021 18:05
@alschmiedt alschmiedt merged commit 92bc3bb into google:goog_module Jul 14, 2021
@cpcallen cpcallen added this to the 2021_q3_release milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moniika moniika moniika approved these changes

@cpcallen cpcallen Awaiting requested review from cpcallen

Assignees
No one assigned
Labels
type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@alschmiedt @moniika @cpcallen