Migrate core/utils/string.js to goog.module syntax #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
reviewed
Jul 15, 2021
core/utils/string.js
Outdated
| @@ -135,44 +138,44 @@ Blockly.utils.string.wrap = function(text, limit) { | |||
| * @return {string} Wrapped text. | |||
| * @private | |||
There was a problem hiding this comment.
Based on the style guide, I don't think this should be marked private. It just doesn't get exported. However, we can wait for Chris to confirm that.
There was a problem hiding this comment.
Updated since this has been long since confirmed, and also updated the exports style to reflect our current convention.
maribethb
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm testlocally already.The details
Resolves
Part of #5026