Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/utils/rect.js to goog.module syntax #5061

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Migrate core/utils/rect.js to goog.module syntax #5061

merged 2 commits into from
Jul 14, 2021

Conversation

moniika
Copy link
Contributor

@moniika moniika commented Jul 14, 2021 •
edited
Loading

The basics

  • I branched from goog_module
  • My pull request is against goog_odule
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test locally already.

The details

Resolves

Part of #5026

Proposed Changes

Converts core/utils/rect.js to goog.module syntax.

Test Coverage

Ran npm run start and npm run test

@moniika moniika requested a review from a team as a code owner July 14, 2021 21:20
@moniika moniika requested a review from BeksOmega July 14, 2021 21:20
BeksOmega
BeksOmega approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after lint fixes.

@moniika moniika force-pushed the convert-rect branch 2 times, most recently from bffd670 to 27b2245 Compare July 14, 2021 22:01
@moniika
Copy link
Contributor Author

moniika commented Jul 14, 2021

LGTM after lint fixes.

This seems to be eslint conflicting with clang-format. I will wait on this PR until we get a consensus on the team on how we want to handle this.

@moniika
Copy link
Contributor Author

moniika commented Jul 14, 2021

LGTM after lint fixes.

This seems to be eslint conflicting with clang-format. I will wait on this PR until we get a consensus on the team on how we want to handle this.

Rebased over the eslint config changes. eslint is now happy.

@moniika moniika merged commit de2cff8 into google:goog_module Jul 14, 2021
@moniika moniika added this to the 2021_q3_release milestone Jul 15, 2021
@moniika moniika deleted the convert-rect branch July 16, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees
No one assigned
Labels
type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@moniika @BeksOmega @cpcallen