Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/utils/metrics.js to goog.module syntax #5064

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Migrate core/utils/metrics.js to goog.module syntax #5064

merged 1 commit into from
Jul 16, 2021

Conversation

moniika
Copy link
Contributor

@moniika moniika commented Jul 15, 2021

The basics

  • I branched from goog.module
  • My pull request is against goog.module
  • My code follows the style guide
  • My code is presented in the form suggeseted in the module
    conversion guide
  • I have run npm test locally already.

The details

Resolves

Part of #5026

Proposed Changes

Converts core/utils/metrics.js to goog.module syntax.

Additional Information

No changes after running clang-format

@moniika moniika requested a review from a team as a code owner July 15, 2021 00:03
@moniika moniika requested a review from alschmiedt July 15, 2021 00:04
@moniika moniika added this to the 2021_q3_release milestone Jul 15, 2021
@moniika moniika merged commit 81b16ab into google:goog_module Jul 16, 2021
@moniika moniika deleted the convert-metrics branch July 16, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alschmiedt alschmiedt alschmiedt approved these changes

Assignees

@alschmiedt alschmiedt

Labels
type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@moniika @alschmiedt @cpcallen