Migrate core/css.js to goog.module syntax #5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
reviewed
Jul 15, 2021
| @@ -78,478 +78,273 @@ const inject = function(hasCss, pathToMedia) { | |||
| */ | |||
| const CONTENT = [ | |||
There was a problem hiding this comment.
I understand why clang-format did this, but ooph...possibly we want to avoid it here?
There was a problem hiding this comment.
Yikes. I'm reverting that commit and I'll see if there's a better way to do this.
I'm thinking either to disable clang for these lines in some way or with a template string.
gonfunko
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm testlocally already.The details
Resolves
Part of #5026
Proposed Changes
Converts
core/css.jstogoog.modulesyntax.