Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/utils/aria.js to goog.module. #5067

Merged
merged 6 commits into from
Aug 12, 2021
Merged

Migrate core/utils/aria.js to goog.module. #5067

merged 6 commits into from
Aug 12, 2021

Conversation

maribethb
Copy link
Contributor

The basics

  • I branched from goog.module
  • My pull request is against goog.module
  • My code follows the style guide
  • My code is presented in the form suggeseted in the module
    conversion guide
  • I have run npm test locally already.

The details

Resolves

Part of #5026

Migrates core/utils/aria.js to goog.module

Additional Information

  • There are no requires statements to change.
  • No changes from clang-format.
  • The file overview comment was incorrectly copied and pasted from keycodes.js so I updated it.

@maribethb maribethb requested a review from a team as a code owner July 15, 2021 00:58
moniika
moniika approved these changes Jul 15, 2021
View reviewed changes
core/utils/aria.js
@@ -5,7 +5,7 @@
*/

/**
* @fileoverview Constant declarations for common key codes.
* @fileoverview ARIA-related constants and utilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cpcallen cpcallen added this to the 2021_q3_release milestone Jul 15, 2021
@maribethb
Copy link
Contributor Author

@moniika Would you mind giving this another look, I updated it to the syntax we decided on later

@moniika moniika self-assigned this Jul 28, 2021
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Aug 12, 2021
@maribethb maribethb merged commit a0bf18c into google:goog_module Aug 12, 2021
@maribethb maribethb deleted the module_aria branch April 1, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moniika moniika moniika approved these changes

@rachel-fenichel rachel-fenichel Awaiting requested review from rachel-fenichel

Assignees

@moniika moniika

Labels
cla: yes Used by Google's CLA checker. type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@maribethb @moniika @cpcallen