Migrate core/blocks.js to goog.module syntax #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Jul 15, 2021
core/blocks.js
Outdated
| @@ -14,10 +14,13 @@ | |||
| * A mapping of block type names to block prototype objects. | |||
| * @name Blockly.Blocks | |||
| */ | |||
| goog.provide('Blockly.Blocks'); | |||
| goog.module('Blockly.Blocks'); | |||
| goog.module.declareLegacyNamespace(); | |||
|
|
|||
| /** | |||
| * A mapping of block type names to block prototype objects. | |||
| * @type {!Object<string,Object>} | |||
There was a problem hiding this comment.
Could you update the type annotation while you're here? I think it should be !Object<string, !Object>. Also I think this needs the dict annotation since outside devs add properties to it.
There was a problem hiding this comment.
I've updated the type, but it seems like the @dict annotation isn't working when I try to build compressed.
I'm not going to add the @dict for now and I'll see about adding it in a future PR.
moniika
force-pushed
the
convert-blocks
branch
2 times, most recently
from
36a5bac to
7381105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm testlocally already.The details
Resolves
Part of #5026
Proposed Changes
Converts
core/blocks.jstogoog.modulesyntax.