Migrate core/utils/dom.js to goog.module syntax #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilFraser
approved these changes
Jul 20, 2021
| Blockly.utils.dom.addClass = function(element, className) { | ||
| var classes = element.getAttribute('class') || ''; | ||
| const addClass = function(element, className) { | ||
| let classes = element.getAttribute('class') || ''; |
There was a problem hiding this comment.
No, on line 117 it gets mutated.
| const createSvgElement = function(name, attrs, opt_parent) { | ||
| const e = /** @type {T} */ | ||
| (document.createElementNS(SVG_NS, String(name))); | ||
| for (const key in attrs) { |
There was a problem hiding this comment.
Isn't this let since it is redefined every loop iteration?
There was a problem hiding this comment.
No, because it is redefined every iteration; it's not the same variable taking on a new value, it's a new variable entirely each time through the loop.
core/utils/dom.js
Outdated
| const classList = classNames.split(' '); | ||
| for (let i = 0; i < classList.length; i++) { | ||
| const cssName = classList[i]; | ||
| removeClass(element, cssName); |
There was a problem hiding this comment.
Just inline cssName, no need for a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm testlocally already.The details
Resolves
Part of #5026