Migrate core/utils/toolbox.js to goog.module syntax

[alschmiedt]

The basics

• I branched from goog_module
• My pull request is against goog_module
• My code follows the style guide
• My code is presented in the form suggested in the module
  conversion guide
• I have run npm test locally already.

The details

Resolves

Part of #5026

Proposed Changes

Converts core/utils/toolbox.js to goog.module syntax.

Additional Information

This is failing this test case. It is because Blockly.utils.toolbox.parseToolboxTree !== parseToolbox. I'm not entirely sure what to do about this. I tried updating the test, but couldn't find a way to require the module with the current set up.

[cpcallen]

I've tweaked the PR title for consistency.

Overall looks good, but the test failure will need to be sorted before merging.

I'm not sure what the best way to do this is: moving to properly encapsulated modules makes the kind of monkey patching that I presume the test is doing no longer work, unfortunately.

[cpcallen]

Any luck figuring out how to modify the tests?

[alschmiedt]

No, not yet. I think the correct way is to import the module (reference here), however we would then have to convert our tests to use goog.module which we can't load in index.html through a scripts tag. You mentioned looking at the blockly_uncompressed.js file, but I have a few questions before moving on.

[alschmiedt]

Removed the test since it should probably be in a separate test suite with the rest of Blockly.utils.toolbox. Filed issue #5139 to track.

[cpcallen]

Seems like a reasonable solution.