Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock to try to unstick dependabot #5184

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

maribethb
Copy link
Contributor

@maribethb maribethb commented Jul 22, 2021

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

All of the dependabot changes have been stuck for a few days with cryptic errors. The internet suggests deleting and regenerating the package lock, which actually upgrades the dependency versions. I've done that here to see if it can kick dependabot back into working.

I kept eslint the same version so we'd have a test case for a dependabot version. But the mocha and generator tests also failed to run for me locally so I also kept webdriverio the same version.

So the versions changed are all the other ones in this list that are NOT major bumps: https://github.com/google/blockly/pulls?q=is%3Apr+is%3Aopen+label%3Adependencies

@blockly/dev-tools, trim-newlines, etc

Test Coverage

Tested with

npm run build
npm run start
npm run test

Tests intermittently fail with php generator errors, this seems unrelated.

Also, I made eslint stay on the old version instead of updating. That way we could try rebasing this PR and see if it works: #5116

Additional Information

I think this started happening after #5038 so if this doesn't work we may need further investigation there.

@maribethb maribethb marked this pull request as ready for review July 23, 2021 00:09
@maribethb maribethb requested a review from a team as a code owner July 23, 2021 00:09
@maribethb maribethb requested a review from gonfunko July 23, 2021 00:09
@maribethb maribethb merged commit f38c782 into google:develop Jul 23, 2021
@maribethb maribethb deleted the broken-bot branch April 1, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants