Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/events/events_theme_change.js to goog.module syntax #5279

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Migrate core/events/events_theme_change.js to goog.module syntax #5279

merged 5 commits into from
Aug 11, 2021

Conversation

gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Aug 2, 2021

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test.

The details

Resolves

Part of #5026

Proposed Changes

Converts core/events/events_theme_change.js to goog.module with ES6 const/let.

@gonfunko gonfunko requested a review from a team as a code owner August 2, 2021 17:52
@gonfunko gonfunko requested a review from maribethb August 2, 2021 17:52
@github-actions github-actions bot added this to the 2021_q3_release milestone Aug 2, 2021
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Aug 11, 2021
@gonfunko gonfunko merged commit 4b6ccf8 into google:goog_module Aug 11, 2021
@gonfunko gonfunko deleted the events_theme_change branch August 11, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribethb maribethb maribethb approved these changes

Assignees

@maribethb maribethb

Labels
cla: yes Used by Google's CLA checker. type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
2 participants
@gonfunko @maribethb