-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename Blockly.connectionTypes to Blockly.ConnectionType #5407
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
160523c
Renamed Blockly.connectionTypes to Blockly.ConnectionType for consist…
himanshujaidka 0c65792
resolved and tested
himanshujaidka 601c17c
Delete blockly_compressed.js
himanshujaidka d7bc360
Revert "Delete blockly_compressed.js"
himanshujaidka dfbfa98
Update blockly_compressed.js
himanshujaidka 27ae3dd
Update blockly.d.ts
himanshujaidka 73f3cf4
Update blockly.d.ts
himanshujaidka 35ad3b2
Merge branch 'goog_module' into UpperCamelCase1
cpcallen 9c64c0b
Revert inadvertent revert of package-lock.json
cpcallen 52145aa
Add entry to renamings.js for renaming of Blockly.connectionTypes
cpcallen ff5d870
renamed ConectionTypes to ConnectionType
himanshujaidka 69d6e14
Merge branch 'goog_module' into UpperCamelCase1
himanshujaidka dee58fe
Merge branch 'goog_module' into UpperCamelCase1
cpcallen a25e390
Rename core/connection_types.js to connection_type.js
cpcallen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ goog.require('Blockly.browserEvents'); | |
goog.require('Blockly.clipboard'); | ||
goog.require('Blockly.common'); | ||
goog.require('Blockly.ComponentManager'); | ||
goog.require('Blockly.connectionTypes'); | ||
goog.require('Blockly.ConnectionTypes'); | ||
goog.require('Blockly.constants'); | ||
goog.require('Blockly.dialog'); | ||
goog.require('Blockly.DropDownDiv'); | ||
|
@@ -412,24 +412,24 @@ Blockly.ALIGN_RIGHT = Blockly.constants.ALIGN.RIGHT; | |
*/ | ||
|
||
/** | ||
* @see Blockly.connectionTypes.INPUT_VALUE | ||
* @see Blockly.ConnectionTypes.INPUT_VALUE | ||
*/ | ||
Blockly.INPUT_VALUE = Blockly.connectionTypes.INPUT_VALUE; | ||
Blockly.INPUT_VALUE = Blockly.ConnectionTypes.INPUT_VALUE; | ||
|
||
/** | ||
* @see Blockly.connectionTypes.OUTPUT_VALUE | ||
* @see Blockly.ConnectionTypes.INPUT_VALUE | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line has extraneous leading and trailing spaces. |
||
*/ | ||
Blockly.OUTPUT_VALUE = Blockly.connectionTypes.OUTPUT_VALUE; | ||
Blockly.OUTPUT_VALUE = Blockly.ConnectionTypes.OUTPUT_VALUE | ||
|
||
/** | ||
* @see Blockly.connectionTypes.NEXT_STATEMENT | ||
* @see Blockly.ConnectionTypes.NEXT_STATEMENT | ||
*/ | ||
Blockly.NEXT_STATEMENT = Blockly.connectionTypes.NEXT_STATEMENT; | ||
Blockly.NEXT_STATEMENT = Blockly.ConnectionTypes.NEXT_STATEMENT; | ||
|
||
/** | ||
* @see Blockly.connectionTypes.PREVIOUS_STATEMENT | ||
* @see Blockly.ConnectionTypes.PREVIOUS_STATEMENT | ||
*/ | ||
Blockly.PREVIOUS_STATEMENT = Blockly.connectionTypes.PREVIOUS_STATEMENT; | ||
Blockly.PREVIOUS_STATEMENT = Blockly.ConnectionTypes.PREVIOUS_STATEMENT; | ||
|
||
/** | ||
* @see Blockly.inputTypes.DUMMY_INPUT | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is one example of a lint error that needs fixing.