fix: add missing requires for Blockly.util.object and Blockly.util.Size
#5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files were using Blockly.utils.object.inherits (or .mixin) without having imported Blockly.utils.object. Similarly, trashcan.js tried to use utils.Size as a constructor instead of importing Size from Blockly.utils.Size.
BeksOmega
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_modulenpm test.The details
Resolves
Part of #5026
Proposed Changes
Add missing requires.
Reason for Changes
Some files were using
Blockly.utils.object.inherits(or.mixin) without having importedBlockly.utils.object.Similarly,
trashcan.jstried to importBlockly.utilsand then useutils.Sizeas a constructor instead of importingSizedirectly fromBlockly.utils.Size.Test Coverage
npm testcompletes successfully.