Migrate hideChaff() from Blockly to WorkspaceSvg #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Sep 15, 2021
Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm test.The details
Resolves
Part of #5208
Proposed Changes
Migrates hideChaff() from Blockly to WorkspaceSvg. This slightly changes the semantics of the method; before, it would hide global modal items (eg tooltips), and autohideables on the main workspace. Since the method is now a workspace instance method, it still hides global modals but hides autohideables on the workspace it is called on. The old behavior can be achieved by
Blockly.common.getMainWorkspace().hideChaff().This PR makes Blockly.hideChaff() deprecated and passes through calls to the main workspace. It also updates core and demos to use the new method.