Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove declareLegacyNamespace() from toolbox/* files #5523

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

moniika
Copy link
Contributor

@moniika moniika commented Sep 23, 2021

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test.

The details

Proposed Changes

Removes declareLegacyNamespace() from files under toolbox/* and adds exports to blockly.js.

@moniika moniika requested a review from a team as a code owner September 23, 2021 17:48
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Sep 23, 2021
@github-actions github-actions bot added this to the 2021_q3_release milestone Sep 23, 2021
@moniika moniika changed the title chore: Remove declareLegacyNamespace() from toolbox/ files chore: Remove declareLegacyNamespace() from toolbox/* files Sep 23, 2021
@moniika moniika merged commit 8bd2e8c into google:goog_module Sep 23, 2021
@moniika moniika deleted the rm-legacy-namespace-toolbox branch September 23, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by Google's CLA checker. type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants