-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert some classes to ES6 classes #5928
Merged
rachel-fenichel
merged 9 commits into
google:develop
from
rachel-fenichel:convert_classes_feb_10
Feb 16, 2022
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b01b042
refactor: move optional function declarations into the constructor
rachel-fenichel 300c259
refactor: convert options.js to es6 class
rachel-fenichel 51c3956
refactor: convert generator.js to es6 class
rachel-fenichel f741d21
refactor: convert workspace_events.js to es6 class
rachel-fenichel cfe0d3e
refactor: convert events_abstract.js to an es6 class
rachel-fenichel 19b254b
chore: format
rachel-fenichel de7af56
chore: fix lint
rachel-fenichel 46f7ffd
chore: rebuild
rachel-fenichel f7950c0
chore: respond to PR feedback
rachel-fenichel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: it might be helpful for readability if the superclass were imported as
AbstractEvent
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done