Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert blocksvg and block to ES6 classes #5952

Merged
merged 11 commits into from
Feb 28, 2022
Merged

refactor: convert blocksvg and block to ES6 classes #5952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a1aa59a
refact: move super call to top of block svg
BeksOmega Feb 16, 2022
da1fbd7
refact: run conversion script on block svg and block
BeksOmega Feb 16, 2022
7dea244
fix: make debug build happy
BeksOmega Feb 17, 2022
c089528
fix: tests
BeksOmega Feb 22, 2022
65a0672
style: format
BeksOmega Feb 22, 2022
e9b6a97
fix: cleanup from rebase
BeksOmega Feb 22, 2022
be0dbfc
fix: use new.target instead of a new parameter
BeksOmega Feb 22, 2022
066b106
fix: add more overridden casted methods to BlockSvg
BeksOmega Feb 25, 2022
9cda247
style: fix typos
BeksOmega Feb 25, 2022
0d3e0af
style: move override tags to the end of JSDoc
BeksOmega Feb 28, 2022
3d6fa7f
fix: cleanup from rebase
BeksOmega Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,669 changes: 1,866 additions & 1,803 deletions core/block.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion core/block_dragger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,8 @@ const BlockDragger = class {
const initIconData = function(block) {
// Build a list of icons that need to be moved and where they started.
const dragIconData = [];
const descendants = block.getDescendants(false);
const descendants =
/** @type {!Array<!BlockSvg>} */ (block.getDescendants(false));
BeksOmega marked this conversation as resolved.
Show resolved Hide resolved

for (let i = 0, descendant; (descendant = descendants[i]); i++) {
const icons = descendant.getIcons();
Expand Down
Loading