-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert the Workspace class to an ES6 class #5977
Merged
BeksOmega
merged 6 commits into
google:develop
from
BeksOmega:refact/workspace-es6-class
Mar 16, 2022
Merged
fix: convert the Workspace class to an ES6 class #5977
BeksOmega
merged 6 commits into
google:develop
from
BeksOmega:refact/workspace-es6-class
Mar 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
reviewed
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I did not get to this earlier. I've added a few comments about the peripheral changes; I will review the changes to workspace.js
tomorrow if @gonfunko hasn't beaten me to them.
gonfunko
approved these changes
Mar 16, 2022
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
More work on #5860
Proposed Changes
Converts the workspace "class" to an ES6 class.
Should be no behavior changes 🤞
Reason for Changes
The long winding road to typescript
Test Coverage
All unit tests pass
Documentation
N/A
Additional Information
N/A