refactor(build): Prepare UMD wrapper generation for transition to ES modules #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that closure-calculate-chunks does not guarantee that calculated chunks will be output in the same order as the entrypoints, so modify getChunkOptions so that it no longer makes that assumption.
Rename the constant NAMESPACE_OBJECT to NAMESPACE_VARIABLE to better explain its actual meaning, and introduce NAMESPACE_PROPERTY to specify what property the namespace object will be stored in (and change the previous value, "internal_", to "__namespace__" to reduce the chance of conflicts with properties created by the output of Closure Compiler).
This is so that chunks whose parent chunk is not the root chunk (chunks[0]) can obtain the namespace object. (See following commit.)
Previously getChunkOptions and chunkWrapper incorrectly assumed that a chunk could have more than one dependency. In fact, each chunk can have only a single dependency, which is its parent chunk. It is used only to retrieve the namespace object, which is saved on to the exports object for the chunk so that any child chunk(s) can obtain it. Update getChunkOptions and chunkWrapper (making the latter longer but more readable) accordingly.
And remove chunk.importAs, since it was no longer being used anywhere.
|
@gonfunko / @alschmiedt: please feel free to apply any suggested changes directly, and then go ahead and merge. |
gonfunko
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #5904.
Proposed Changes
Makes various changes to the way UMD chunk wrappers are generated. Specifically:
closure-calculate-chunksoutputs chunks in the same order as the--entrypoints were specified on the command line.NAMESPACE_PROPERTYto control where the namespace object is saved on the exports object.Behaviour Before Change
The namespace object is saved only on the
.internal_property of the first (blockly) chunk's exports object.Behaviour After Change
The namespace object is saved on the
.__namespace__property of every chunk's exports object.Reason for Changes
goog.module.declareLegacyNamespacecalls.Test Coverage
npm test.Documentation
Additional Information