fix: opening/closing the mutators #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we use an arrow function for this since we're ES6 now? |
|
Oh probably, but actually I tested a bit more and it looks like this fails when we delete the block so going to probably put the initial fix in place which was to hav |
rachel-fenichel
approved these changes
Mar 16, 2022
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#5999
Proposed Changes
Add
.bind(this)for the mutator and check that the block is not null before calling saveConnections. Calling saveConnections was causing problems when the block was deleted becausethis.block_was coming back null.Reason for Changes
Fixing bugs.
Test Coverage
Documentation
Additional Information