Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable ts for the clang-format workflow #6225

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

N/A

Proposed Changes

Enables the format action to format ts files.

Behavior Before Change

The format workflow would fail because it couldn't find any files.

Behavior After Change

The format workflow succeeds (hopefully). But I can't test. Changes are based on: https://github.com/DoozyX/clang-format-lint-action

Reason for Changes

Get CI working for typescript.

Test Coverage

N/A

Documentation

N/A

Additional Information

Follow up to: https://github.com/google/blockly/pull/6220/files

@BeksOmega BeksOmega requested a review from a team as a code owner June 17, 2022 21:17
@BeksOmega BeksOmega requested review from NeilFraser and removed request for a team June 17, 2022 21:17
@BeksOmega BeksOmega merged commit 6132229 into google:master Jun 21, 2022
@BeksOmega
Copy link
Collaborator Author

I don't know why this is still failing. It's definitely supposed to be a comma-separated list of file extensions (see here and here). But for some reason it's still running with "--extensions" "js".

@cpcallen
Copy link
Contributor

cpcallen commented Jun 22, 2022

This will only affect commits to pull requests targetting the master branch. Did you mean to commit it to develop instead?

@BeksOmega
Copy link
Collaborator Author

This will only affect commits to pull requests targetting the master branch. Did you mean to commit it to develop instead?

Oh I thought that workflows had to be defined in whatever the main branch of the repository is (like issue and PR templates). Turns out they need to exist on the branch you're merging in, aka the branch your PR is associated with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants