Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update message loading to work for wrapped and unwrapped message files. #6334

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

maribethb
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

#6123

Proposed Changes

  • This is a patch release containing fix: Make message files work in unpackaged mode, and rebuild msg files #6329 and rebuilt files.
  • Update version number to 8.0.5
  • Run npm run build and npm run checkin:built. I actually did this before updating the version number and there were no changes. After updating the version number there are now changes to all of the .map files, so I assume these are legitimate changes related to the source code in blockly_compressed changing, even though I don't have an explanation for what those might be. But I'm going to assume that Closure Compiler is working correctly here.

Tested this via a subset of the tests I ran yesterday covering the three use cases:

  • imported blockly via a module
  • script tags requiring wrapped messages
  • script tags requiring unwrapped messages

@maribethb maribethb requested a review from a team as a code owner August 10, 2022 20:44
@maribethb maribethb requested review from BeksOmega and removed request for a team August 10, 2022 20:44
@maribethb maribethb merged commit 55a7076 into google:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants