feat: add accessor for the workspace svg group #7394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Work on #7157
Proposed Changes
Adds public accessor for
svgGroup_
.Reason for Changes
This is necessary for the scroll options plugin to add a wheel listener, and for the multiselect plugin to add a mouse enter listener.
Test Coverage
N/A
Documentation
N/A
Additional Information
I didn't make
getBlockCanvas
public because I realized the scroll options plugin is only using it to get the transform. I think we should either be able to use the metrics, or justscrollX
andscrollY
to do that instead.App Inventor asked that I fix the
svgGroup_
issue this quarter so they don't need to worry about the multiselect plugin breaking (in this way) in the future.