Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accessor for the workspace svg group #7394

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Work on #7157

Proposed Changes

Adds public accessor for svgGroup_.

Reason for Changes

This is necessary for the scroll options plugin to add a wheel listener, and for the multiselect plugin to add a mouse enter listener.

Test Coverage

N/A

Documentation

N/A

Additional Information

I didn't make getBlockCanvas public because I realized the scroll options plugin is only using it to get the transform. I think we should either be able to use the metrics, or just scrollX and scrollY to do that instead.

App Inventor asked that I fix the svgGroup_ issue this quarter so they don't need to worry about the multiselect plugin breaking (in this way) in the future.

@BeksOmega BeksOmega requested a review from a team as a code owner August 14, 2023 17:51
@github-actions github-actions bot added the PR: feature Adds a feature label Aug 14, 2023
@rachel-fenichel
Copy link
Collaborator

I didn't make getBlockCanvas public because I realized the scroll options plugin is only using it to get the transform. I think we should either be able to use the metrics, or just scrollX and scrollY to do that instead.

Using metrics might work but be very slow--just something to keep an eye out for.

@BeksOmega BeksOmega merged commit b602f21 into google:develop Aug 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants