-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add muted option #7714
feat: add muted option #7714
Conversation
Heya @truongductri01 let me know when you've had a chance to test this, then I'll give it a review =) |
Heya @truongductri01 are you still interested in working on this? I'll check back in a week and close it if not! |
Hi @BeksOmega , I am so sorry for the late response. I have tried to test it in the playground demo but really not sure how to call the setMuted on the workspace to mute the sound. Could you give me a hint? |
Can you send what you tried based on my previous comment? |
Actually, I have found the way to test it. Using this code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and this looks great!
Just a few changes to docs then I think this should be good to go =)
Co-authored-by: Beka Westberg <bwestberg@google.com>
Co-authored-by: Beka Westberg <bwestberg@google.com>
Co-authored-by: Beka Westberg <bwestberg@google.com>
Co-authored-by: Beka Westberg <bwestberg@google.com>
I make the commits based on your suggestions. Let me know if something else needed to be done |
The basics
I am not sure how to set up a virtual workspace and test the audio yet
The details
Resolves
Fixes: #7669
Proposed Changes
Reason for Changes
Test Coverage
Documentation
Additional Information