Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: delete deprecations for v11. #7732

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Dec 19, 2023

The basics

The details

Resolves

Fixes N/A Delete deprecations

Proposed Changes

Deletes all of the deprecations we said we would delete in v11.

Reason for Changes

Getting rid of dead code :D

Test Coverage

All tests pass.

Documentation

N/A

Additional Information

N/A

Breaking changes / To fix

Any items that were marked as deprecated have now been removed. Before updating you should check if you are getting any deprecation warnings and fix them.

@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Dec 19, 2023
@BeksOmega BeksOmega marked this pull request as ready for review December 19, 2023 23:48
@BeksOmega BeksOmega requested a review from a team as a code owner December 19, 2023 23:48
@BeksOmega BeksOmega marked this pull request as draft December 19, 2023 23:52
@BeksOmega BeksOmega changed the base branch from rc/v11.0.0 to v11-breaks January 8, 2024 22:23
@BeksOmega BeksOmega marked this pull request as ready for review January 8, 2024 22:23
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jan 8, 2024
Copy link
Contributor

@NeilFraser NeilFraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I haven't seen 'path' for a while.

@BeksOmega BeksOmega merged commit 4f1a442 into google:v11-breaks Jan 10, 2024
7 checks passed
BeksOmega added a commit that referenced this pull request Jan 23, 2024
* chore: delete basic deprecations

* chore: remove deprecated align enum

* chore: remove generator deprecation

* chore: format
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants