Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export save and load procedure #7806

Merged

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes N/A

Proposed Changes + Reasons

We need to export the save and load functions because the save and load functions deal with parameters, while the functions on the procedure classes do not.

The events in samples need to be able to serialize and deserialize procedures properly.

Test Coverage

N/A

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner January 25, 2024 21:59
@github-actions github-actions bot added the PR: fix Fixes a bug label Jan 25, 2024
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but why is this going directly into the rc/ branch and not develop (since it's not a breaking change)? My understanding is the rc branches are only used to cut releases so they should only contain cherry-picks if they aren't just a straight copy of develop.

@BeksOmega
Copy link
Collaborator Author

lgtm but why is this going directly into the rc/ branch and not develop (since it's not a breaking change)? My understanding is the rc branches are only used to cut releases so they should only contain cherry-picks if they aren't just a straight copy of develop.

Dependent on #7740 which only exists in the RC branch, because it is breaking.

@BeksOmega
Copy link
Collaborator Author

lgtm but why is this going directly into the rc/ branch and not develop (since it's not a breaking change)? My understanding is the rc branches are only used to cut releases so they should only contain cherry-picks if they aren't just a straight copy of develop.

Oh skimmed over the second part of your message. We're handling all the breaking changes in the rc branch this quarter so that we can do a minor release from develop mid quarter.

@BeksOmega BeksOmega merged commit 016bc73 into google:rc/v11.0.0 Jan 25, 2024
10 checks passed
@BeksOmega BeksOmega deleted the fix/export-proc-serialization branch May 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants