Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shouldPreventMove not being respected #7894

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes N/A

#4886 never actually worked.

Proposed Changes

Makes it so that shouldPreventMove is actually respected.

Test Coverage

Manually tested by linking to the backpack plugin.

  • Dragging an orphaned block moves it back to the old location on the workspace.
  • Dragging a child block reattaches it to parent.
  • Dragging a parent block (holding ctrl to heal stack) reattaches to child.
  • Dragging a middle block (holding ctrl to heal stack) reattaches to parent and child.
  • Dragging from the simple flyout toolbox bumps blocks into bounds.

Documentation

N/A

Additional Information

I'm going to release a beta of 10.5 for this for app inventor so they can test with it.

@ewpatton
Copy link
Contributor

I've tested with the beta version @BeksOmega sent and we have deployed in our Blockly update test server.

core/block_dragger.ts Outdated Show resolved Hide resolved
core/block_dragger.ts Outdated Show resolved Hide resolved
@BeksOmega BeksOmega merged commit 7c7dfd0 into google:develop Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants