fix!: classes on text input bubble to match comment view #7935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
Makes the text input bubble css consistent with the workspace comment css. Yay for styling.
Test Coverage
Manually checked that everything still looks correct in LTR and RTL.
Documentation
Will need to start documenting CSS classes somewhere.
Additional Information
If/when we move the workspace comments into a plugin, we'll need to do something with the CSS for the resize handle because right now the text input bubble is relying on it. One option is to just move that CSS into the text input bubble class.
Breaking changes / To fix
If you were using the
blocklyCommentTextArea
CSS class to style comment icons, you should use.blocklyTextInputBubble .blocklyTextArea
instead.If you were using the
blocklyResizeSE
CSS class, you should use.blocklyResizeHandle
instead.If you were using the
blocklyResizeSW
CSS class, you should use.blocklyRtl .blocklyResizeHandle
instead.