Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: classes on text input bubble to match comment view #7935

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Mar 14, 2024

The basics

The details

Resolves

Fixes N/A

Proposed Changes

Makes the text input bubble css consistent with the workspace comment css. Yay for styling.

Test Coverage

Manually checked that everything still looks correct in LTR and RTL.

Documentation

Will need to start documenting CSS classes somewhere.

Additional Information

If/when we move the workspace comments into a plugin, we'll need to do something with the CSS for the resize handle because right now the text input bubble is relying on it. One option is to just move that CSS into the text input bubble class.

Breaking changes / To fix

If you were using the blocklyCommentTextArea CSS class to style comment icons, you should use .blocklyTextInputBubble .blocklyTextArea instead.

If you were using the blocklyResizeSE CSS class, you should use .blocklyResizeHandle instead.

If you were using the blocklyResizeSW CSS class, you should use .blocklyRtl .blocklyResizeHandle instead.

@BeksOmega BeksOmega requested a review from a team as a code owner March 14, 2024 16:36
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Mar 14, 2024
@BeksOmega BeksOmega merged commit e91dd20 into google:rc/v11.0.0 Mar 14, 2024
11 checks passed
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants