Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dragging): Introduce Dragger, implementing IDragger #7956

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

cpcallen
Copy link
Contributor

The basics

The details

Resolves

Fixes #7839.

Proposed Changes

Introduce a concrete Dragger class, implementing IDragger.

Having decided to delegate dealing with drag targets (and in particular delete areas) to the drag strategy, this class does not have much left in it.

Reason for Changes

Support custom dragging.

Test Coverage

Passes npm test.

@cpcallen cpcallen added the PR: feature Adds a feature label Mar 22, 2024
@cpcallen cpcallen requested a review from BeksOmega March 22, 2024 16:40
@cpcallen cpcallen requested a review from a team as a code owner March 22, 2024 16:40
@github-actions github-actions bot removed the PR: feature Adds a feature label Mar 22, 2024
@github-actions github-actions bot added the PR: feature Adds a feature label Mar 22, 2024
core/dragging/dragger.ts Show resolved Hide resolved
@cpcallen cpcallen enabled auto-merge (squash) March 22, 2024 19:02
@cpcallen cpcallen merged commit 0588dfa into google:rc/v11.0.0 Mar 22, 2024
6 checks passed
@cpcallen cpcallen deleted the feat/dragger branch March 23, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants