feat: add block drag strategy #7970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: feature
BeksOmega
force-pushed
the
feat/drag-block-dragger
branch
from
ffad2d4
to
9395112
Compare
core/dragging/block_drag_strategy.ts
Outdated
| const {local: currLocal, neighbour: currNeighbour} = currCandiate; | ||
| const localPos = new Coordinate(currLocal.x, currLocal.y); | ||
| const neighbourPos = new Coordinate(currNeighbour.x, currNeighbour.y); | ||
| const distance = Coordinate.distance( |
There was a problem hiding this comment.
distance -> currDistance
BeksOmega
force-pushed
the
feat/drag-block-dragger
branch
from
9395112
to
7d55936
Compare
rachel-fenichel
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7840
Proposed Changes
Adds a block drag strategy to confirm to the new dragging API. Most of this is just taken from the existing block dragger.
Test Coverage
Tested with following PRs that change the gesture system. Once those are in I can do some more thorough testing.
Documentation
N/A
Additional Information
Dependent on #7968