feat: Add snapping to workspace comments. #8070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that there are two things that snap (blocks and WS comments), the alignment code in being moved to a common place.
cpcallen
approved these changes
May 8, 2024
core/grid.ts
Outdated
| * @returns Object with .x and .y properties in workspace coordinates, | ||
| * or null if no change. | ||
| */ | ||
| alignXY(xy: Coordinate): Coordinate | null { |
There was a problem hiding this comment.
This name seems OK but doesn't really hint at the fact that the function will return null if the argument was already a grid point.
Co-authored-by: Christopher Allen <cpcallen+git@google.com>
Co-authored-by: Christopher Allen <cpcallen+git@google.com>
The point of null was to avoid creating a new coordinate object and avoid a more complicated check. But this can also be achieved by returning the original input coordinate object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there are two things that snap (blocks and WS comments), the alignment code in being moved to a common place.
Resolves #8060