Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added id to rendered ws comments; made getCommentById public; ad… #8358

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

changminbark
Copy link
Contributor

…ded blocklyDraggable class to ws comments

The basics

The details

Resolves

Fixes #8242 and #8253

Proposed Changes

This exposes the rendered workspace comment id in the DOM. It also makes the workspace getCommentById function public. It also added the blocklyDraggable class to the DOM of rendered workspace comments.

Reason for Changes

This will help with the support of the implementation of workspace comments in the multiselect plugin. This is mainly needed as the multiselect plugin uses dragSelect to select the elements' DOM. The id in the DOM is then passed to a respective get[element]ById function to manipulate/work with the actual object (in this case workspace comments).

Test Coverage

I tested this by looking at the HTML of the page and seeing whether it had the added classes and data-id field.

Documentation

Documentation regarding rendered workspace comments having a data-id field may be added, but it would not be of the utmost concern.

Additional Information

@changminbark changminbark requested a review from a team as a code owner July 14, 2024 07:07
Copy link

google-cla bot commented Jul 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change!

@rachel-fenichel rachel-fenichel merged commit 4cdca28 into google:develop Jul 16, 2024
11 checks passed
gonfunko pushed a commit to gonfunko/blockly that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface workspace comments' IDs in the DOM
2 participants