Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @hyperjump/json-schema from 1.6.7 to 1.9.3 #8363

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 15, 2024

Bumps @hyperjump/json-schema from 1.6.7 to 1.9.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner July 15, 2024 10:03
@dependabot dependabot bot added PR: chore General chores (dependencies, typos, etc) PR: dependencies Pull requests that update a dependency file labels Jul 15, 2024
@dependabot dependabot bot requested a review from cpcallen July 15, 2024 10:03
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Jul 15, 2024
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Jul 17, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/develop/hyperjump/json-schema-1.9.3 branch from a651f81 to 09490cb Compare July 17, 2024 15:25
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Jul 17, 2024
@cpcallen
Copy link
Contributor

cpcallen commented Jul 17, 2024

Test failures are due to a breaking change in @hyperjump/json-schema without a corresponding major version bump; this has been reported as hyperjump-io/json-schema#68. Workaround is to add a devDependency on @hyperjump/browser.

@cpcallen
Copy link
Contributor

…and there was another breaking change without major version bump in a later commit, now added to description of hyperjump-io/json-schema#68. How many more, I wonder?

@cpcallen cpcallen removed their request for review July 18, 2024 15:07
@cpcallen cpcallen removed their assignment Jul 18, 2024
@cpcallen
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 18, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot bot and others added 5 commits July 18, 2024 17:17
Bumps [@hyperjump/json-schema](https://github.com/hyperjump-io/json-schema) from 1.6.7 to 1.9.3.
- [Commits](hyperjump-io/json-schema@v1.6.7...v1.9.3)

---
updated-dependencies:
- dependency-name: "@hyperjump/json-schema"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@hyperjump/json-schema (v1.7.0 and later) depends upon
@hyperjump/browser, but fails to declare it as a dependency,
only listing it as a peer dependency, so said package must be
installed separately.
See issue hyperjump-io/json-chema#68 for additional info.
Since the BASIC output of the schema verifier is (slightly) less
helpful than the old DETAILED output, add an additional output
containing the first invalid path, e.g.:

    #/9.3.0/0/exports/textToDom/newModule

in the results object returned by validate, since this is the
most useful part of that info.

Also use console.error and console.info instead of console.log
where appropriate.
@cpcallen cpcallen force-pushed the dependabot/npm_and_yarn/develop/hyperjump/json-schema-1.9.3 branch from 58c911e to 193d197 Compare July 18, 2024 16:17
@cpcallen
Copy link
Contributor

OK, looks like this is ready for review, now that the tests actually pass.

@cpcallen cpcallen merged commit 8cad97a into develop Jul 19, 2024
12 checks passed
@cpcallen cpcallen deleted the dependabot/npm_and_yarn/develop/hyperjump/json-schema-1.9.3 branch July 19, 2024 10:22
Arun-cn pushed a commit to Arun-cn/blockly that referenced this pull request Jul 24, 2024
…8363)

* chore(deps): bump @hyperjump/json-schema from 1.6.7 to 1.9.3

  Bumps [@hyperjump/json-schema](https://github.com/hyperjump-io/json-schema) from 1.6.7 to 1.9.3.
  - [Commits](hyperjump-io/json-schema@v1.6.7...v1.9.3)

  ---
  updated-dependencies:
  - dependency-name: "@hyperjump/json-schema"
    dependency-type: direct:development
    update-type: version-update:semver-minor
  ...

  Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): Add dev dependency on @hyperjump/browser

  @hyperjump/json-schema (v1.7.0 and later) depends upon
  @hyperjump/browser, but fails to declare it as a dependency,
  only listing it as a peer dependency, so said package must be
  installed separately.

* fix(tests): Use BASIC output as DETAILED is no longer supported

  See issue hyperjump-io/json-chema#68 for additional info.

* feat(tests): Add more informational output in case of test failure

  Since the BASIC output of the schema verifier is (slightly) less
  helpful than the old DETAILED output, add an additional output
  containing the first invalid path, e.g.:

      #/9.3.0/0/exports/textToDom/newModule

  in the results object returned by validate, since this is the
  most useful part of that info.

  Also use console.error and console.info instead of console.log
  where appropriate.

* chore(tests): Format

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christopher Allen <cpcallen+git@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc) PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants