Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comments and bubbles on click #8451

Merged

Conversation

UCYT5040
Copy link
Contributor

@UCYT5040 UCYT5040 commented Aug 1, 2024

The basics

The details

Resolves

Fixes
#7675 (#7675)

Proposed Changes

  1. Workspace comments now move to the block layers when selected.
  2. All bubbles (including block comments) move to the top layer when selected.

Reason for Changes

The comments/bubbles raise when dragged a pixel, so it make sense for them to be raised when they are selected.

Test Coverage

I don't see how automated tests could be used here.

I tested the changes with comments, block comments, and bubbles opened by mutators.

Documentation

No changes needed

Additional Information

No additional information

@UCYT5040 UCYT5040 requested a review from a team as a code owner August 1, 2024 13:32
@UCYT5040 UCYT5040 requested a review from gonfunko August 1, 2024 13:32
Copy link

google-cla bot commented Aug 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for gonfunko August 2, 2024 19:40
@BeksOmega BeksOmega assigned BeksOmega and unassigned gonfunko Aug 2, 2024
@BeksOmega BeksOmega changed the title Raise comments and bubbles on click fix: comments and bubbles on click Aug 2, 2024
@github-actions github-actions bot added the PR: fix Fixes a bug label Aug 2, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thank you for the fix! Once it passes CI I'll get it merged =)

@BeksOmega BeksOmega merged commit f020b54 into google:develop Aug 2, 2024
13 checks passed
@gonfunko gonfunko mentioned this pull request Nov 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants