fix: Let workspace comment have delete cursor over trash. #8477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8413
Proposed Changes
This removes an obsolete CSS property on the workspace comment top bar that overrides the mouse cursor style to be the grab cursor. Other CSS rules affecting the workspace comment have the same cursor, and additionally switch to a different cursor when dragging over the trash can, so removing this property allows those switches to take effect.
Reason for Changes
The CSS property was added in e4b734c a couple months ago and was necessary at the time because there wasn't any other style at the time that provided the drag cursor for workspace comments. However, 4cdca28 was added more recently and provides the drag cursor for the parent element along with the necessary variations, making the previous commit obsolete.
Test Coverage
I manually tested the mouse cursor behavior for dragging workspace comments over the trash can.