-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post-install DB opatch issues #125
base: master
Are you sure you want to change the base?
Conversation
When testing a 12.2 RAC install, which has an extra HAS patch, I ran into two issues with the opatch logic: 1. Unlike the GI install, the DB install is out of place, and runInstaller actually clobbers existing content in the ORACLE_HOME, including the OPatch executable. Therefore we need to update OPatch _after_ the install has compelted, but before invoking it to apply one-off patches 2. The opatch output display runs a loop over the appy_oneoff results, in order to handle multiple patches if necessary. To display the output for the given patch, we need to print {{ item.xxx }} objects instead of the static {{ apply_oneoff }} ones.
/test bms-toolkit-install |
@@ -153,8 +153,8 @@ | |||
- name: rac-db-install | opatch output | |||
debug: | |||
msg: | |||
- "{{ apply_oneoff.cmd }}" | |||
- "{{ apply_oneoff.stdout_lines }}" | |||
- "{{ item.cmd }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this task rac-db-install | opatch output
may be backed out, as a recent PR for EL8.5 fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I will merge into current HEAD once approved.
@@ -137,6 +122,21 @@ | |||
- "{{ install_rac_db }}" | |||
tags: rac-db,rac-db-install | |||
|
|||
- name: rac-db-install | Update DB OPatch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, the task block rac-db-install | Update DB OPatch
has been moved in this PR after the task rac-db-install | Set installer command
.
Upon eyeballing the pre & post blocks, it seems the content is same. Does the new ordering have any functionality effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed the order does matter.
Unlike the GI install, the DB install is out of place, and runInstaller actually clobbers existing content in the ORACLE_HOME, including the OPatch executable. Therefore we need to update OPatch after the install has completed, but before invoking it to apply one-off patches
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfielding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When testing a 12.2 RAC install, which has an extra HAS patch, I ran into two issues with the opatch logic:
ORACLE_HOME
, including the OPatch executable. Therefore we need to update OPatch after the install has completed, but before invoking it to apply one-off patches{{ item.xxx }}
objects instead of the static{{ apply_oneoff }}
ones.